Help: Fix linter warnings and simplify logic around tracking the offline form event

[omarjackman]

I saw some linter warnings after a rebase and then decided to fix them and try to simplify the logic here a bit.

How to test
Target a group where there is only one operator and make sure the operator is available. Also enable calyspo:analytics debugging

1. Navigate to http://calypso.localhost:3000/help/contact
2. Notice the "Chat with us" variation of the contact form.
3. Set the olark operator to away.
4. You should notice that the form has changed to the "Submit support ticket" variation.
5. Also notice in the javascript console that an event has been recorded for calypso_help_offline_form_display with a form_type of "kayako".

What to expect

[omarjackman]

cc @dllh

[omarjackman]

I felt I should show my work here just so someone else could try and spot a mistake. Here's how I reduced it

showKayakoVariation = ! showChatVariation && ( details.isConversing || isUserEligible );
showKayakoVariation = ! ( isUserEligible && details.isOperatorAvailable ) && ( details.isConversing || isUserEligible ); // substitute showChatVariation for its actual value
showKayakoVariation = ! ( isUserEligible && false ) && ( details.isConversing || isUserEligible ); // We already know operators aren't available so lets replace details.isOperatorAvailable with false because we are in the onOperatorsAway callback
showKayakoVariation = ! ( false ) && ( details.isConversing || isUserEligible ); // simplify
showKayakoVariation = true && ( details.isConversing || isUserEligible ); // simplify
showKayakoVariation = ( details.isConversing || isUserEligible ); // simplify
showKayakoVariation = details.isConversing || isUserEligible; //simplify
showKayakoVariation = false || isUserEligible; // Our if statement above indicates that details.isConversing should be false so lets fill it in
showKayakoVariation = isUserEligible; // simplify
showKayakoVariation = true; // If a user is not eligible to start a chat and they aren't currently chatting then they'd
                            // never experience an "offline" contact form. In this case isUserEligible will always be true.

[omarjackman]

After staring at this long enough I realize that the "forum" case should theoretically never happen. If a user is not eligible to start a chat and they aren't currently chatting then they'd never experience an "offline" contact form. The form would always just be the "Ask in the forums" variation. This means that we can simplify showKayakoVariation further and just set it to true and this could just be form_type: 'kayako'.

[dllh]

Hmm, I'm not sure this follows. What if we change what eligibility for chat means? For example, we have greater availability to offer chat to users with subscriptions right now, but when we have capacity to expand that, I think we'd have a case of users who are not currently eligible for chat who might be in the future. Or, to try to outline it since this is sort of confusing, a future scenario might look like this:

1. A user who has no subscriptions loads the form.
2. We have capacity to offer chat to that user.
3. The user initiates a chat.
4. Operators go away.
5. We need to show an offline message.

Wouldn't we still need to record the forum event in this case?

[dllh]

We talked this over a bit in Slack and walked through the simplification together, and the logic seems valid to me. 🚢