Form Toggles: Clean up of old styles and unused component pieces #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added a cursor: default style to the disabled toggle component 2. Noticed that we still had the old pre-componentized toggle styles in _forms.scss, removed them (I got tripped up because I started out editing that and saw no change in devdocs) 3. Noticed there was an unused plugin-toggle component that was ditched in favor of the form-toggle component, removed it 4. Noticed that the name server page in Domains used the old toggle styles and made an ugly first pass at switching to the component
rickybanister
added
[Status] Needs Review
|
Name servers toggle LGTM 👍 |
|
everything looks ok to me! And it's nice to see so much red in a PR :)
|
johnHackworth
added
[Status] Ready to Merge
and removed
[Status] Needs Review
rickybanister
pushed a commit
that referenced
this pull request
Dec 16, 2015
Form Toggles: Clean up of old styles and unused component pieces
lancewillett
removed
the
[Status] Needs Design Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be no visual changes except no longer seeing a pointer cursor for disabled toggles.
I'll ask if @breezyskies would be so kind as to make sure I didn't cause a regression in the name servers stuff. It looks the same, but not sure if anything is broken or if the correct screen reader label is being passed now.
I'll ask @mtias if he would take a look at what I've done
I'll ask if @johnHackworth would make sure I didn't break anything in Plugins