-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framework: remove <Flag> component #1676
Conversation
9f0ff8a
to
2fcc280
Compare
6fcada6
to
16b5677
Compare
👍 Privacy protection icon looks good now. |
Awesome, thanks for looking. |
Also removes margins from core component.
fb01924
to
78af584
Compare
Framework: remove <Flag> component
@breezyskies: <Notice
isCompact
status="is-warning"
icon="notice"
onClick={ this.goToPrivacyProtection }>
{ this.translate( 'None', {
context: 'An icon label when Privacy Protection is disabled.'
} ) }
</Notice> @mtias: would it be ok to add |
I think it should be wrapped, since |
Opened a PR for this in #1740. |
This removes the
<Flag>
component in favour of<Notice isCompact>
.Test
This should cover all existing use cases of Flag. cc @scruffian @breezyskies
This is the one I could spot myself:
May need some tweaks for the line.