Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: remove <Flag> component #1676

Merged
merged 6 commits into from
Dec 16, 2015
Merged

Conversation

mtias
Copy link
Member

@mtias mtias commented Dec 16, 2015

This removes the <Flag> component in favour of <Notice isCompact>.


Test

This should cover all existing use cases of Flag. cc @scruffian @breezyskies

This is the one I could spot myself:

image

May need some tweaks for the line.

@mtias mtias added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Components [Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature Group] WPCOM Store & Purchases All things billing on WordPress.com. This includes the backend store, plans, and billing management. labels Dec 16, 2015
@breezyskies
Copy link
Contributor

Overall, this looks good. Noticed this one seems to be missing the icon (should be lock):

screen_shot_2015-12-16_at_8_24_53_am

@mtias mtias force-pushed the update/remove-flag-component branch from 9f0ff8a to 2fcc280 Compare December 16, 2015 17:41
@mtias mtias force-pushed the update/remove-flag-component branch from 6fcada6 to 16b5677 Compare December 16, 2015 17:59
@mtias
Copy link
Member Author

mtias commented Dec 16, 2015

The TLDs look like this:

image

@breezyskies
Copy link
Contributor

👍 Privacy protection icon looks good now.

@mtias
Copy link
Member Author

mtias commented Dec 16, 2015

Awesome, thanks for looking.

@mtias mtias force-pushed the update/remove-flag-component branch from fb01924 to 78af584 Compare December 16, 2015 18:28
mtias added a commit that referenced this pull request Dec 16, 2015
@mtias mtias merged commit 0f55ded into master Dec 16, 2015
@mtias mtias deleted the update/remove-flag-component branch December 16, 2015 18:51
@scruffian scruffian removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 16, 2015
@gziolo
Copy link
Member

gziolo commented Dec 17, 2015

@breezyskies: onClick doesn't work for privacy protection None icon, should we bring back this behavior or remove callback:

<Notice
    isCompact
    status="is-warning"
    icon="notice"
    onClick={ this.goToPrivacyProtection }>
    { this.translate( 'None', {
        context: 'An icon label when Privacy Protection is disabled.'
    } ) }
</Notice>

@mtias: would it be ok to add onClick handler to Notice component or should we wrap it with another element?

@mtias
Copy link
Member Author

mtias commented Dec 17, 2015

I think it should be wrapped, since Notice is neither a button nor a link in itself.

@breezyskies
Copy link
Contributor

I think it should be wrapped, since Notice is neither a button nor a link in itself.

Opened a PR for this in #1740.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Components [Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature Group] WPCOM Store & Purchases All things billing on WordPress.com. This includes the backend store, plans, and billing management. Framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants