Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Fixes clipping of focus styles on section header buttons #1656

Merged
merged 1 commit into from
Dec 18, 2015

Conversation

ebinnion
Copy link
Contributor

Fixes an issue that @rickybanister reported in Slack where the focus styles of a button within SectionHeader get clipped on the left side.

cc @rickybanister for design review

After

screen shot 2

Before

slack-imgs com

@ebinnion ebinnion added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR labels Dec 16, 2015
@ebinnion ebinnion self-assigned this Dec 16, 2015
@rickybanister
Copy link

I guess I'd like to get @mtias or @MichaelArestad's take on whether this is the right solution (adding 2px of left margin) before we merge this one.

It does fix it, but I don't know the best way to fix this.

@MichaelArestad
Copy link
Contributor

Looks like it is being covered up by another section. Try position: relative on .section-header__actions instead of the margin.

@MichaelArestad
Copy link
Contributor

If that breaks something else (with layering), we can add padding-left: 2px instead.

@ebinnion ebinnion force-pushed the fix/section-header-button-focus-clip branch from 5a18fd1 to d32c95e Compare December 18, 2015 18:00
@ebinnion
Copy link
Contributor Author

@rickybanister @MichaelArestad Just pushed up a commit that fixes the issue with position: relative; I'm not exactly sure why that works, but it does seem to do the trick.

I tested a few instances of SectionHeader and it seemed to be 👍

@MichaelArestad
Copy link
Contributor

Cool. WFM.

ebinnion added a commit that referenced this pull request Dec 18, 2015
…cus-clip

Framework: Fixes clipping of focus styles on section header buttons
@ebinnion ebinnion merged commit cd53828 into master Dec 18, 2015
@ebinnion ebinnion deleted the fix/section-header-button-focus-clip branch December 18, 2015 22:00
@lancewillett lancewillett removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants