Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signup: update step module names to match step names #1543

Merged
merged 2 commits into from
Dec 23, 2015
Merged

Signup: update step module names to match step names #1543

merged 2 commits into from
Dec 23, 2015

Conversation

oskosk
Copy link
Contributor

@oskosk oskosk commented Dec 14, 2015

Updates email-signup-form and site-creation signup steps directories and require statements to use these names for consistency as proposed by #767 :

client/signup/steps/email-signup-form -> client/signup/steps/user
client/signup/steps/site-creation ->client/signup/steps/site`

Testing instructions

  • While logged out, go to http://calypso.localhost:3000/start/developer
  • Make sure the signup flow lets you reach the site selection and user registration steps.
  • Make sure that input padding and suffix styles for the site selection step was not affected

@oskosk oskosk added [Status] In Progress [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. labels Dec 14, 2015
@oskosk oskosk force-pushed the update/update-step-module-names-to-match-step-names branch from 24b1564 to f48d889 Compare December 14, 2015 13:58
@oskosk oskosk self-assigned this Dec 14, 2015
@oskosk oskosk added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Dec 14, 2015
@oskosk
Copy link
Contributor Author

oskosk commented Dec 14, 2015

cc @scruffian

@oskosk oskosk mentioned this pull request Dec 14, 2015
Closed
@oskosk oskosk force-pushed the update/update-step-module-names-to-match-step-names branch from f48d889 to 84a4fe3 Compare December 18, 2015 17:24
@scruffian
Copy link
Member

LGTM 👍

@scruffian scruffian added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 21, 2015
@oskosk
Rename email-signup-form step to user
8a37e41 
The User step will be called UserSignupComponent in signup/config/step-components.js
@oskosk
Rename site-creation step to site
f9289f1
@oskosk oskosk force-pushed the update/update-step-module-names-to-match-step-names branch from 84a4fe3 to f9289f1 Compare December 23, 2015 17:19
oskosk added a commit that referenced this pull request Dec 23, 2015
@oskosk
Merge pull request #1543 from Automattic/update/update-step-module-na…
af36274 
…mes-to-match-step-names

Update/update step module names to match step names
@oskosk oskosk merged commit af36274 into master Dec 23, 2015
@oskosk oskosk deleted the update/update-step-module-names-to-match-step-names branch December 23, 2015 17:29
@sirbrillig sirbrillig changed the title Update/update step module names to match step names Signup: update step module names to match step names Dec 23, 2015
This was referenced Apr 7, 2022
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oskosk oskosk

Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oskosk @scruffian