-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout: Block removal of Private Registration from cart only when renewing #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@scruffian @fabianapsimoes: Can you confirm it doesn't break anything? |
@@ -24,6 +24,18 @@ function applyCoupon( coupon ) { | |||
}; | |||
} | |||
|
|||
function canRemoveFromCart( cart, cartItem ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function fits much better in cart related logic.
115ed5e
to
051b6d4
Compare
This works properly and improves the quality of the code it touches. I tested both domain cases. LGTM. |
051b6d4
to
d2e5725
Compare
gziolo
added a commit
that referenced
this pull request
Dec 17, 2015
…stration Checkout: Block removal of Private Registration from cart only when renewing
Thanks @drewblaisdell for review! :) |
This was referenced Apr 7, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Checkout
The checkout screen and process for purchases made on WordPress.com.
[Feature Group] Emails & Domains
Features related to email integrations and domain management.
[Status] In Progress
[Type] Bug
When a feature is broken and / or not performing as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1410.
Steps to reproduce:
Testing