Add translate calls to strings in SectionHeader docs #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deBhal
added
[Status] Needs Review
| @@ -14,7 +14,7 @@ render: function() { | |||
| return ( | |||
| <SectionHeader label={ this.translate( 'Team' ) }> | |||
| <Button compact> | |||
| Manage | |||
| this.translate( 'Manage' ) } | |||
ebinnion
force-pushed
the
update/add-translate-calls-to-section-header-docs
branch
from
c5c48ee to
ff757c1
Compare
|
I rebased against master to fix a conflict after #1533 (removes Card component from docs example) got merged. I also went ahead and added the missing LGTM. Thanks for the explanation in this comment. |
ebinnion
added a commit
that referenced
this pull request
Dec 14, 2015
…o-section-header-docs Add translate calls to strings in SectionHeader docs
scruffian
removed
the
[Status] Needs Review
ebinnion
deleted the
update/add-translate-calls-to-section-header-docs
branch
|
Thanks @ebinnion! |
|
Thanks! |
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds translate() calls to strings in SectionHeader, as suggested in #1468
You can see the example with the translate calls works at http://calypso.localhost:3000/devdocs/design/section-header and you can check that the strings won't go out to translators by running
make translateand then checkingcalypso-strings.phpboth from the top directory of calypso.@ebinnion: I've opened this PR because I feel bad about being away and missing the other PR, not to be pushy. If you feel like the example stands better without the changes, feel free to comment to that effect and close