Reader: fix sidebar list highlight #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluefuton
added
[Type] Bug
|
Still seems a bit buggy. Here's what I'm seeing: |
blowery
force-pushed
the
fix/reader-sidebar-highlight
branch
from
e0ba6a2 to
48078b9
Compare
|
📌 Rebased this after the React 0.14 merge and force pushed |
|
Ah. The I think we just need to strip the last URL segment and compare that. I'm on it. |
bluefuton
added
[Status] In Progress
and removed
[Status] Needs Review
bluefuton
added
[Status] Needs Review
|
No more double 'blah' highlight :)
|
…eir URL from highlighting concurrently
…so Following Management has launched
blowery
force-pushed
the
fix/reader-sidebar-highlight
branch
from
1f47b64 to
49373a8
Compare
blowery
added a commit
that referenced
this pull request
Dec 22, 2015
Reader: fix sidebar list highlight
scruffian
removed
the
[Status] Needs Review
|
Thanks @blowery! |
6 tasks
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that only the current list is highlighted in the Reader sidebar.
Previously, it was possible for multiple lists to be highlighted at the same time if they shared the same beginning to their URL (fixes #1523).
### To testCreate two Reader lists with a common start to their name (e.g. giraffe1 and giraffe2).
Choose the list in the sidebar, and ensure that only the chosen list is highlighted.
Then choose the Manage button for your chosen list, again ensuring that only the chosen list is highlighted.