-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Adds LoggedOutForm component #1521
Conversation
import Card from 'components/card'; | ||
|
||
module.exports = React.createClass( { | ||
displayName: 'LoggedOutFormFooter', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing propTypes: {} The same is true for the rest of the new components.
I left some minor comments. Overall in my testing I didn't find any errors beside the once that you pointed out already. I was able to accept the invitation + create a new user and a new site. |
@enejb I went ahead and |
c95d99c
to
f94e09a
Compare
What's the email-address-only 'log me in' form for? The footer looks good in all the examples. This seems like a useful refactor. |
@rickybanister I'm not entirely sure. I think it was an attempt at mobile login, but it hasn't launched yet. The idea seems to be that you enter your email, and then you'll receive a one time pin which you can enter in the next step. But, the form was broken against |
Tested and everything seems to work including |
Components: Adds LoggedOutForm component
In an effort to factor the logged out link that shows at the bottom of the form at
/start/account/user
and to allow reuse of the logged out form styles, this PR refactors thesignup/logged-out-form
component and brings much of its functionality toclient/components/logged-out-form-container
component.cc @mtias and @rickybanister for design review, @lezama, and @drewblaisdell for code review.
To test:
add/components-logged-out-form
branch$site/wp-admin/users.php?page=wpcom-invite-users
/accept-invite/$site/$invite_key
/start/account/user
/start/site-user/site
Note: You'll notice that the
/log-in
form is off centered, and during testing you will likely run into a JS error if you try to submit the form on/log-in
. This is not related to this PR and/log-in
is only enabled indevelopment
.Also note: In some screenshots you'll notice there's quite a bit of padding between the form footer and the input directly above it. This seems to be caused by:
I intentionally added a screenshot with an invalid form field so that you could see what that would look like.
After screenshots:





