Me: Fixes 2fa via app layout #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebinnion
added
[Status] In Progress
[Feature] User & Account Settings (/me)
ebinnion
force-pushed
the
fix/me-2fa-layout
branch
from
a8d2a19 to
ff011ab
Compare
ebinnion
added
[Status] Needs Review
ebinnion
force-pushed
the
fix/me-2fa-layout
branch
from
ff011ab to
e019de0
Compare
|
Soooo much better! 👍 |
| className="security-2fa-enable__toggle" | ||
| onClick={ function( event ) { | ||
| analytics.ga.recordEvent( 'Me', 'Clicked On Barcode Toggle Link', 'current-method', this.state.method ); | ||
| this.toggleMethod( event ); |
There was a problem hiding this comment.
Minor thing, but I would put toggleMethod before the analytics.ga. Since it is more important then the analytics event.
|
The flow is so much better! I think this could be fixed as part of this PR. :) |
|
Thanks for the reviews. I created the above issue to tackle the steps header in a separate issue/PR. |
|
Looks good feel free to merge! 👍 |
enejb
added
[Status] Ready to Merge
and removed
[Status] Needs Review
lancewillett
removed
the
[Status] Needs Design Review
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #232
Previously, the 2fa via app flow layout was essentially broken on mobile 😞. This PR fixes that.
cc @rickybanister for design review and @enejb for code review.
To test:
fix/me-2fa-layoutbranch/me/security/two-stepwhile logged in to a test accountAfter screenshots:
Before screenshot:
