Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup: Free trials: Only show free trials on signup in the dev environment #1423

Merged
merged 1 commit into from
Dec 11, 2015

Conversation

scruffian
Copy link
Member

This enables free trials in signup in dev.

Fixes #1417

Testing

  1. git checkout update/1417-free-trials-in-signup
  2. Open http://calypso.localhost:3000/start incognito
  3. Assert that you are show the "Start free trial" button.
  • Code review
  • QA review

@scruffian scruffian added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. Free Trials labels Dec 9, 2015
@scruffian scruffian self-assigned this Dec 9, 2015
@scruffian scruffian added this to the No-cc Free Trials: v1 milestone Dec 9, 2015
@ghost
Copy link

ghost commented Dec 9, 2015

Trial adds a year long subscription instead of just 14/17 days.

@fabianapsimoes fabianapsimoes added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 9, 2015
@fabianapsimoes
Copy link
Contributor

A few issues related to problems in this flow, just so we make sure to close them before merging this:

@fabianapsimoes
Copy link
Contributor

Trial adds a year long subscription instead of just 14/17 days.

Just adding that this seems to happen in all cases of trial signup: from /start with a new account, from /start for an existing account, and from /plans for an existing site. We're testing this proxied and unsandboxed.

@fabianapsimoes
Copy link
Contributor

We tested this a bit more:

  • not proxied, not sandboxed: no free trial flow, you see the credit card form (which is expected).
  • proxied, not sandboxed: free trial flow, but full subscription instead of a 14-day one.
  • proxied, sandboxed: free trial flow, and a 14-day subscription (which is how it should work).

@scruffian
Copy link
Member Author

This patch should fix those issues: pb-10333

@ghost
Copy link

ghost commented Dec 11, 2015

Works from the scruffian sandbox - 👍

@fabianapsimoes fabianapsimoes added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Author Reply labels Dec 11, 2015
@drewblaisdell
Copy link
Contributor

👍

@drewblaisdell drewblaisdell added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 11, 2015
@scruffian scruffian force-pushed the update/1417-free-trials-in-signup branch from e76fc47 to e362b8d Compare December 11, 2015 20:57
scruffian added a commit that referenced this pull request Dec 11, 2015
…ignup

Signup: Free trials: Only show free trials on signup in the dev environment
@scruffian scruffian merged commit 2f6dc1d into master Dec 11, 2015
@scruffian scruffian deleted the update/1417-free-trials-in-signup branch December 11, 2015 21:05
@scruffian scruffian restored the update/1417-free-trials-in-signup branch December 12, 2015 00:03
@lancewillett lancewillett deleted the update/1417-free-trials-in-signup branch December 22, 2015 19:13
@scruffian scruffian removed their assignment Jan 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants