Publicize: add linkedin preview #14198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copied comment from @iamtakashi :
|
jhnstn
force-pushed
the
add/publicize-linkedin-preview
branch
from
d1f0f5d to
dc3d4f1
Compare
matticbot
added
[Size] XL
a8ci18n
reviewed
May 20, 2017
| @@ -13,6 +13,7 @@ import SocialLogo from 'social-logos'; | |||
| const services = translate => ( { | |||
| facebook: { icon: 'facebook', label: translate( 'Facebook feed' ) }, | |||
| google: { icon: 'google', label: translate( 'Google search' ) }, | |||
| google_plus: { icon: 'google-plus', label: translate( 'Google+ ' ) }, | |||
There was a problem hiding this comment.
Hi! I've found a possible matching string that has already been translated 55 times:
translate( 'Google' ) ES Score: 11
See 2 additional suggestions in the PR translation status page
Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).
jhnstn
force-pushed
the
add/publicize-linkedin-preview
branch
from
dc3d4f1 to
5852ad2
Compare
matticbot
added
[Size] L
jhnstn
force-pushed
the
add/publicize-linkedin-preview
branch
from
5852ad2 to
9953ccc
Compare
jhnstn
added
the
[Status] Needs Design Review
|
@iamtakashi Adding the company name is bit tricky given the way access linkedin account information. Here is what we have now in this PR:
|
jhnstn
requested review from
retrofox,
rralian,
iamtakashi,
sirbrillig,
artpi and
lamosty
jhnstn
added
[Feature] Sharing
jhnstn
force-pushed
the
add/publicize-linkedin-preview
branch
from
9953ccc to
8b734d3
Compare
|
FWIW, the comment here (#14198 (comment)) is not how I see shares show up in Linkedin. Next to the avatar I see, three lines:
In any case, let's merge this for now and we can tweak the design in a followup. I've tested and it works as designed. |
rralian
approved these changes
May 23, 2017
rralian
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
Thanks @rralian |
This was referenced May 30, 2021
This was referenced Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Linkedin to publicize preview.
Testing
calypso.localhost:3000:ENABLE_FEATURES=publicize-scheduling make runbreaks up #12644