SiteSelector: Remove selector state binding

[mcsf]

Part of #14024

Also fixes keyboard navigation in SiteSelector, a feature knowingly broken in #13094 and introduced in #5808.

Testing

Try to switch sites, select all sites, etc., in different Calypso sections. Try to switch sites with the mouse, the keyboard, both. Site switching should continue to work as expected; keyboard navigation should now be working properly, e.g.:

• open the site switcher
• hover the mouse over a site; the site should become highlighted
• without further moving the mouse, navigate up or down with the keyboard
• the highlighting should move up or down starting from the previously highlighted site

[matticbot]

Test live: https://calypso.live/?branch=remove/site-selector-state-binding

[mcsf]

• Are there precendents of such thunks that never dispatch any action and instead only call getState and perform some side effect (in this case, page call)?

Note that, in the future, if we add middleware-level routing support (e.g. dispatch( { type: 'NAVIGATE', path } ), the above becomes a "normal" thunk which calls getState in order to have sufficient data to then dispatch a routing request.

• The remaining question: given its nature, where should this action creator live?

[johnHackworth]

I'm not sure if I'm doing something wrong when testing, but it doesn't seem to work for me. Neither it hightlights the site on mouse over or the keyboard navigation works... Am I missing something? :/

[mcsf]

@johnHackworth, this is what you should be seeing:

First I'm moving my mouse and hovering over sites, then I switch to Up/Down arrows on my keyboard.

[johnHackworth]

hmm, I'm not sure what's going on, but this is me doing the same while running this branch on my localhost:

[johnHackworth]

maybe chrome/linux related?

[mcsf]

It's working on all of Firefox, Chrome, and Safari on my Mac. It may be Linux-related.

[johnHackworth]

Hmm, I've just tested and it works fine in firefox/linux ... it looks like it's a chrome/linux (Versión 56.0.2924.87 (64-bit) ) issue

[marekhrabe]

I was the original author of keyboard navigation for this component. With this fix in place, it looks like we have the desired behavior working again. Thanks for fixing it :)

Regarding the code, I like the move of navigation code out of the compoenent and making it an action. Not sure where it should live to be honest…

[marekhrabe]

Functionality works and I'm fine merging as-is, unless we have more usages for navigation actions or you just wanna dig deeper. Once we have more, it might be a good idea to collocate them.

[mcsf]

Not sure where it should live to be honest…

For now, I honestly wouldn't mind to leave it there, as it's very component-specific and doesn't dispatch anything. Anyone who feels strongly otherwise can just point it out. :)

[mcsf]

Once we have more, it might be a good idea to collocate them.

Agreed, but let's move. Thanks for the review!