SitesDropdown: Don't bind selectors to state #14026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsf
added
Framework
Sites
[Status] Needs Review
4 tasks
mcsf
force-pushed
the
remove/sites-dropdown-selector-state-binding
branch
from
da7594a to
220b1ad
Compare
tyxla
reviewed
May 16, 2017
|
|
||
| componentDidMount() { | ||
| const { initialSiteId, setSelectedSiteSlug } = this.props; | ||
| setSelectedSiteSlug( initialSiteId ); |
There was a problem hiding this comment.
It feels really odd to pass an ID to something that expects a slug ❓
There was a problem hiding this comment.
True; an artifact of the first pass. I should rename to id. :)
There was a problem hiding this comment.
Actually, ID on its own would clash with a prop that is part of SitesDropdown's public interface, so I'm changing to locallySelectedSiteId.
mcsf
force-pushed
the
remove/sites-dropdown-selector-state-binding
branch
from
5d5a009 to
4cf2ada
Compare
This is the explicit way to do it. The mechanism of adding a wrapper that holds the state upstream of `connect` could easily be abstracted into a `connectWithState` function.
mcsf
force-pushed
the
remove/sites-dropdown-selector-state-binding
branch
from
4cf2ada to
578e1e8
Compare
|
Rebased against |
matticbot
removed
the
[Status] Needs Review
This was referenced Jun 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14024
Testing
SitesDropdownis used inSiteSelectorModal(via ellipsis actions at/themes),/me/account,HelpContactForm. Behaviors should remain unchanged.