-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notices: remove site-notice component #1364
Conversation
This is great, thanks, has been on my list for a while. Once we also convert |
Question: do we need to show the full menu below in this case? Otherwise, the entire side column could be a custom designed component for this instance :) |
@artpi I think the original text is fine, the only purpose of this notice is to help distinguish between the site that redirects and the site that it redirects to when you have both in your list. |
I'd keep things as they were, just getting rid of the custom component. And we'll look at any improvements once we work on "flags". |
Sounds good. I'm working on flags now. |
Squash and |
Notices: notices/site-notice->components/notice in current-site Notices: fix bottom margin in notices displayed in sidebar So it matches previous design of site-notice class. Notices: Remove unused css of site-notice The component is no longer uses and will be removed shortly Notices: Remove unused site-notice component
2ecaea2
to
8c34746
Compare
Notices: remove site-notice component
Part of notices refactor intitiative:
#888 #1094 #1105 #1313
This component was only used once and didn't add much additional functionality.
Plus, design-wise, after clicking domain name, the user was redirected to domain management, which was kind of confusing.
Design changes
Before:

After:

Why would you put so much text there?
This is actually the most important information in the whole site right now.
I am wondering if it should be put in a permanent global notice, because no matter what people change in Calypso, they wont see anything on the frontend.
And when I was searching for a way to turn off redirection, I had to dig around A LOT.
@mtias: Any suggestions how to make this look good?
Testing