Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes: Redirect /themes to /design #12730

Merged
merged 1 commit into from
Apr 3, 2017
Merged

Themes: Redirect /themes to /design #12730

merged 1 commit into from
Apr 3, 2017

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Apr 3, 2017 •
edited by folletto
Loading

Step 1 of p4axMe-1jd-p2. Enables Calypso to handle /themes routes, redirecting them to /design.

To test:
Land on a couple of different /themes routes (with different combinations of tier/vertical/filter/search string), and observe that you are being redirected to the corresponding /design route.

Note that in production (and staging?), /themes still routes to Atlas, so this PR won't have any visible effect there yet. Step 2 will be to route /themes to Calypso instead.

@ockham ockham added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 3, 2017
@ockham ockham self-assigned this Apr 3, 2017
@ockham ockham requested review from folletto, seear and budzanowski April 3, 2017 13:48
@matticbot
Copy link
Contributor

matticbot commented Apr 3, 2017 •
edited by folletto
Loading

Test live: https://calypso.live/themes?branch=add/themes-to-design-redirect

@matticbot matticbot added the [Size] S Small sized issue label Apr 3, 2017
@ockham ockham mentioned this pull request Apr 3, 2017
Merged
@folletto
Copy link
Contributor

folletto commented Apr 3, 2017 •
edited
Loading

Testing URLs:

  1. https://calypso.live/themes?branch=add/themes-to-design-redirect
  2. https://calypso.live/themes/filter/breadcrumb-navigation,responsive-layout,blog?branch=add/themes-to-design-redirect
  3. https://calypso.live/themes/?s=dog&branch=add/themes-to-design-redirect
  4. https://calypso.live/themes/filter/bright,blog?s=one&branch=add/themes-to-design-redirect
  5. https://calypso.live/themes/business?branch=add/themes-to-design-redirect

@folletto
Copy link
Contributor

folletto commented Apr 3, 2017 •
edited
Loading

All work (tested both in live and localhost) except:

❌ /themes/?s=dog and /themes?s=dog

@ockham ockham force-pushed the add/themes-to-design-redirect branch from b7f6fc5 to 8d77c73 Compare April 3, 2017 14:19
@ockham
Copy link
Contributor Author

ockham commented Apr 3, 2017

Should be fixed (by amending the commit, so you might've to restart calypso.live).

folletto
folletto approved these changes Apr 3, 2017
View reviewed changes
Copy link
Contributor

@folletto folletto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok tested, looking good now 👍

seear
seear approved these changes Apr 3, 2017
View reviewed changes
Copy link
Contributor

@seear seear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested logged out as well.

👍

@ockham ockham merged commit f06e748 into master Apr 3, 2017
@ockham ockham deleted the add/themes-to-design-redirect branch April 3, 2017 17:39
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 3, 2017
@folletto folletto added this to the Themes: Showcase M6-TheOne milestone Apr 3, 2017
@ockham ockham mentioned this pull request Apr 4, 2017
Merged
@awaisab172 awaisab172 mentioned this pull request Nov 30, 2023
Open
@awaisab172 awaisab172 mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@folletto folletto folletto approved these changes

@seear seear seear approved these changes

@budzanowski budzanowski Awaiting requested review from budzanowski

Assignees

@ockham ockham

Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Size] S Small sized issue
Projects
None yet
Milestone
Themes: Showcase M6-TheOne
Development

Successfully merging this pull request may close these issues.
4 participants
@ockham @matticbot @folletto @seear