Happychat: Middleware refactor of HAPPYCHAT_SET_MESSAGE #12565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwondra
added
Happychat
[Status] Needs Review
Alphabetize! Alphabetize... again Update middleware helper function to have better name
mattwondra
force-pushed
the
update/happychat/middleware-refactor/set-chat-message
branch
from
4a55987 to
2217fe1
Compare
southp
approved these changes
Mar 29, 2017
| it( 'should send the connection a typing signal when a message is present', () => { | ||
| const action = { type: HAPPYCHAT_SET_MESSAGE, message: 'Hello world' }; | ||
| const connection = { typing: spy() }; | ||
| middleware( connection )()( spy() )( action ); |
There was a problem hiding this comment.
Since we are not really interested in what's happening to the next function here, could we consider to use noop from lodash instead of creating a spy instance here? It would be a little bit light weighted and the "don't care" intention would be clearer.
| it( 'should send the connection a notTyping signal when the message is blank', () => { | ||
| const action = { type: HAPPYCHAT_SET_MESSAGE, message: '' }; | ||
| const connection = { notTyping: spy() }; | ||
| middleware( connection )()( spy() )( action ); |
mattwondra
added
[Status] Ready to Merge
and removed
[Status] Needs Review
mattwondra
deleted the
update/happychat/middleware-refactor/set-chat-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves side effects related to
HAPPYCHAT_SET_MESSAGEactions into the middleware. Part of an ongoing refactor.HAPPYCHAT_SET_MESSAGEupdates the controlled form input state in the Happychat composer when a user types. The side effect is that the remote operator is informed when the user starts and stops typing.To test
happychatsubtree. Themessagekey should initially have a value''happychat.messageshould be syncing in real-time with your changes