Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix display issues in Calypso ascii art #1252

Merged
merged 1 commit into from
Dec 5, 2015

Conversation

stephanethomas
Copy link
Contributor

This pull request fixes few display issues in the ascii art displayed in the console when starting Calypso and in the HTML source of each page:

Before
vagrant@calypso:/var/sources$ make run
    ___ __ _| |_   _ _ __  ___  ___
  / __/ _\` | | | | | '_ \/ __|/ _ \
  | (_| (_| | | |_| | |_) \__ \ (_) |
   \___\__,_|_|\__, | .__/|___/\___/
               |___/|_|

Hash: 81b6ed3ffaa88e373253
Version: webpack 1.12.6

...
After
vagrant@calypso:/var/sources$ make run
             _
    ___ __ _| |_   _ _ __  ___  ___
   / __/ _` | | | | | '_ \/ __|/ _ \
  | (_| (_| | | |_| | |_) \__ \ (_) |
   \___\__,_|_|\__, | .__/|___/\___/
               |___/|_|

Hash: 81b6ed3ffaa88e373253
Version: webpack 1.12.6

...

Testing instructions

  1. Execute make run and check the welcome message displayed in the console
  2. Navigate to any page of Calypso and check the banner displayed in the header of the HTML source

/cc @nb, @folletto

@stephanethomas stephanethomas self-assigned this Dec 3, 2015
@stephanethomas stephanethomas added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 3, 2015
@gwwar
Copy link
Contributor

gwwar commented Dec 4, 2015

     _     _       _ _   
 ___| |__ (_)_ __ (_) |_ 
/ __| '_ \| | '_ \| | __|
\__ \ | | | | |_) | | |_ 
|___/_| |_|_| .__/|_|\__|
            |_|          

@gwwar gwwar added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 4, 2015
@ehg
Copy link
Member

ehg commented Dec 4, 2015

 __         __            
|  |.-----.|  |_.--------.
|  ||  _  ||   _|        |
|__||___  ||____|__|__|__|
    |_____|               

This adds missing lines and remove unnecessary backslashes to the welcome message displayed in the console as well as the banner displayed in the HTML source of each page.
stephanethomas added a commit that referenced this pull request Dec 5, 2015
Build: Fix display issues in Calypso ascii art
@stephanethomas stephanethomas merged commit cbe0ef4 into master Dec 5, 2015
@stephanethomas stephanethomas deleted the fix/calypso-ascii-art branch December 5, 2015 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants