Framework: Fixes uncentered logged-out layouts with no sidebar #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebinnion
added
Framework
[Status] Needs Review
ebinnion
force-pushed
the
fix/logged-out-sidebar-layout
branch
from
1e97e80 to
a5613f0
Compare
drewblaisdell
added
[Type] Bug
|
LGTM. |
ebinnion
added a commit
that referenced
this pull request
Dec 3, 2015
Framework: Fixes uncentered logged-out layouts with no sidebar
ghost
mentioned this pull request
This was referenced Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1077 and #901
In #1077, I reported that logged out layouts without a sidebar were still off-center even after #302. After looking into this more, it looks like it was because there's a
client/layout/logged-out.jsxcomponent that wasn't updated to add thehas-no-sidebarclass. This PR fixes that.cc @shaunandrews @scruffian for review
To test:
fix/logged-out-sidebar-layoutbranch/start.$site/wp-admin/users.php?page=wpcom-invite-usersand send an invitation to an email you have access to me$invitation_key/accept-invite/$site/$invitation_keyAfter screenshots: