-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
People: Invites: Redirect and display notice on invite dismiss #1184
Conversation
export default React.createClass( { | ||
|
||
displayName: 'InviteAcceptLoggedIn', | ||
|
||
render() { | ||
let userObject = user.get(), | ||
const { user } = this.props, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Code-wise, this LGTM. Functionally, I only noticed the one thing about notices. I wouldn't expect a green notice for declining here. Pinging @rickybanister for a design review and advice. |
I think the blue is-info notice is the correct way to go here. And just to be sure—you'd only be redirected to the Reader if you decline after clicking a link in an email while logged in—that is to say you are redirected to If you click the join or decline button in a notification it would not redirect you anywhere (as in the screenshot above) |
Thanks! changed it to
Yes
We are not dealing with notifications right now, but we will have this in mind.. |
…notice-on-dismiss People: Invites: Redirect and display notice on invite dismiss
Fixes #1146
This PR displays a notice when declining and invite and redirects the user to the reader
To test
update/invites-redirect-and-notice-on-dismiss
Decline Invite
$site/wp-admin/users.php?page=wpcom-invite-users
/accept-invite/$site/$invite_key
cc @ebinnion