Themes: Hide upload eligibility card if no messages #11433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are no holds or warnings to display, simply show the upload dropzone. This removes the need for the user to click the 'Proceed' button on an empty 'Conflicts' card.
seear
added
[Feature Group] Appearance & Themes
This was referenced Feb 16, 2017
|
First load does not have full eligibility data. |
* Use `isEligible...` selector to show card before data loads to get placeholders * Ensure we set local state when data has loaded
Nice catch. Addressed in 48cdf41 Makes use of the eligibility card's own placeholders if the data is not yet loaded. |
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are no holds or warnings to display, simply show the upload dropzone. This removes the need for the user to click the 'Proceed' button on an empty 'Conflicts' card.
To Test
Go to http://calypso.localhost:3000/design/upload and view for different sites.
No errors/warnings before
No errors/warnings after
Note this PR should not interfere with the redesign to the eligibility component in #11394