Stats: use svg country flags instead of gravatar hosted flags. #11412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmyc
added
[Feature] Stats
youknowriad
approved these changes
Feb 16, 2017
youknowriad
added
[Status] Ready to Merge
and removed
[Status] Needs Review
timmyc
force-pushed
the
udpate/stats/country-flags
branch
from
2112e84 to
04da1a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the flag images for the Stats Countries module are hosted on Gravatar. There was a bug in Gravatar which caused some of these flag images to be cached incorrectly, resulting in broken images showing in Calypso ( pMz3w-6xv-p2 ). In lieu of tracking down a fix there, I have opted to create this branch which utilizes svg country flags that are already present in Calypso.
These flag svgs are already being used in the
<PhoneInput />component, and since they are available, it makes sense to utilize them here as well. For reference, the svg images are copied via webpack from the following project: https://github.com/lipis/flag-icon-css. In my testing, the flag set is a bit more current than the gravatar images, and has a flag for the EU - which we do not have on Gravatar.Before ( Note broken gravatar images and misssing EU )
After
