Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes: fix forum URL to show even without site selected #11296

Merged
merged 1 commit into from
Feb 9, 2017
Merged

Themes: fix forum URL to show even without site selected #11296

merged 1 commit into from
Feb 9, 2017

Conversation

folletto
Copy link
Contributor

@folletto folletto commented Feb 9, 2017

There's a bug where Theme Sheet support Forum URLs don't show up unless a site is selected. This PR fixes it.

Props: @ockham

Before:

screen shot 2017-02-09 at 15 11 05

This PR:

screen shot 2017-02-09 at 15 11 08

To test:

  • Open My Sites → Themes
  • Check the Support pages for a Free Theme + Single Site
  • Check the Support pages for a Free Theme + All Sites (no site in URL)
  • Check the Support pages for a Premium Theme + Single Site
  • Check the Support pages for a Premium Theme + All Sites (no site in URL)

The forum URL should show up every time, and change from generic volunteer one to the specific one for Premium themes.

@folletto folletto added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 9, 2017
@folletto folletto added this to the Themes: JetPress Rally milestone Feb 9, 2017
@folletto folletto self-assigned this Feb 9, 2017
@folletto folletto requested a review from ockham February 9, 2017 15:13
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/theme-sheet-forum-url

seear
seear approved these changes Feb 9, 2017
View reviewed changes
Copy link
Contributor

@seear seear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@seear seear merged commit b23a70a into master Feb 9, 2017
@seear seear deleted the fix/theme-sheet-forum-url branch February 9, 2017 15:22
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 9, 2017
@folletto folletto mentioned this pull request Feb 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seear seear seear approved these changes

@ockham ockham Awaiting requested review from ockham

Assignees

@folletto folletto

Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites.
Projects
None yet
Milestone
Themes: JetPress Rally
Development

Successfully merging this pull request may close these issues.
3 participants
@folletto @matticbot @seear