Support: Add seo and marketing video to help courses #11278
Conversation
omarjackman
added
[Feature Group] Support
omarjackman
changed the title
| { videos.map( ( video, key ) => <CourseVideo { ...video } key={ key }/> ) } | ||
| <Card compact className="help-courses__course-videos-label"> | ||
| { translate( | ||
| 'Latest course', |
There was a problem hiding this comment.
Hi! I've found a possible matching string that has already been translated 20 times:
translate( 'Latest course' ) ES Score: 16.82
See 1 additional suggestion in the PR translation status page
Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).
omarjackman
added
[Status] Needs Review
| description: i18n.translate( | ||
| 'You will leave this 60-minute session with a plan for optimizing your site for search engines ' + | ||
| 'and an overview of basic tactics for increasing your traffic. Our Happiness Engineers will provide a' + | ||
| 'foundation for making sure that your site meets current SEO standards. We\'ll also discuss how to ' + |
There was a problem hiding this comment.
Not sure why the a8ci18n bot didn't post here, but the string is missing a space between "a" and "foundation". See https://translate.wordpress.com/localci/status/automattic/wp-calypso/update/help-course-videos/add-seo-video
There was a problem hiding this comment.
@yoavf Maybe thats what the "See 1 additional suggestion in the PR translation status page" in the message was referring to. Either way I didn't notice it, thanks for pointing it out.
|
This looks good to me, but we should probably also remove the "Next course" block, since now we're showing a course for Feb. 2 and then the video for the same course below. With that change, I'm cool with it and ok to 🚢 |
@dllh you just pointed out a flaw in the data structure that drives this page. The original intention was to show a course followed by videos for that course. It's not a huge deal but It's not as easy as deleting a data row. I'll need to rethink it a bit. |
|
The changes in the pull request were added in #11399 |
matticbot
removed
the
[Status] Needs Review
This pull request adds the youtube video containing the latest help course video for seo and marketing.
How to test
What to expect