Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sites: fix missing margin on every 3rd card in mobile #1082

Merged
merged 1 commit into from
Dec 1, 2015
Merged

Sites: fix missing margin on every 3rd card in mobile #1082

merged 1 commit into from
Dec 1, 2015

Conversation

gwwar
Copy link
Contributor

@gwwar gwwar commented Dec 1, 2015

Fixes #5 by removing an unneeded media query. I've tested this in IE11, Edge, Chrome, FF but please confirm.

To test:

  1. Navigate to calypso.localhost:3000/sites
  2. Make sure your device has a small viewport <480px, or resize the browser window until the cards collapse to a single column
  3. Make sure spacing looks correct for all cards.

Before:
e301b9c8-8d1a-11e5-86b3-8271f573e447

After:
fixed

cc @alisterscott @mtias

@gwwar gwwar added Sites [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 1, 2015
@alisterscott
Copy link
Contributor

Re-tested PR successfully on Chrome, Firefox. No other issues identified.

(attached correct image this time)

picker mobile

@mtias
Copy link
Member

mtias commented Dec 1, 2015

👍

@mtias mtias added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 1, 2015
gwwar added a commit that referenced this pull request Dec 1, 2015
@gwwar
Merge pull request #1082 from Automattic/fix/sites-spacing-5
60f99c7 
Sites: fix missing margin on every 3rd card in mobile
@gwwar gwwar merged commit 60f99c7 into master Dec 1, 2015
@gwwar gwwar deleted the fix/sites-spacing-5 branch December 1, 2015 17:04
@gwwar gwwar self-assigned this Dec 4, 2015
@gwwar gwwar added this to the Core: Iteration 17 milestone Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gwwar gwwar

Labels
Sites
Projects
None yet
Milestone
Core: Iteration 17
Development

Successfully merging this pull request may close these issues.

Sites: Gap/space missing between sites for every 3rd site
4 participants
@gwwar @alisterscott @mtias @scruffian