Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invites: Centers text in logged in accept buttons #1078

Merged
merged 1 commit into from
Dec 2, 2015
Merged

Invites: Centers text in logged in accept buttons #1078

merged 1 commit into from
Dec 2, 2015

Conversation

ebinnion
Copy link
Contributor

To test:

  • Checkout update/invites-center-button-text branch
  • Create an invite at $site/wp-admin/users.php?page=wpcom-invite-users
  • In the invitation email that you receive, make note of the invitation key
  • Go to /accept-invite/$site/$invite_key while you are logged in
  • Is the text within the buttons centered?

cc @rickybanister for a design review

After:
screen shot

Before:
screen shot 2

@ebinnion ebinnion added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR People Management labels Nov 30, 2015
@ebinnion ebinnion self-assigned this Nov 30, 2015
@ebinnion ebinnion added this to the People Management: m6 milestone Nov 30, 2015
@roccotripaldi
Copy link
Member

looks like a rebase is needed.

@ebinnion ebinnion force-pushed the update/invites-center-button-text branch from c13a915 to 23561d0 Compare December 1, 2015 22:16
@ebinnion
Copy link
Contributor Author

ebinnion commented Dec 1, 2015

Thanks for pointing that out. I just rebased and pushed.

@ebinnion ebinnion force-pushed the update/invites-center-button-text branch from 23561d0 to a139356 Compare December 1, 2015 23:19
@rickybanister
Copy link

The buttons look good to go.

ebinnion added a commit that referenced this pull request Dec 2, 2015
@ebinnion
Merge pull request #1078 from Automattic/update/invites-center-button…
db818bb 
…-text

Invites: Centers text in logged in accept buttons
@ebinnion ebinnion merged commit db818bb into master Dec 2, 2015
@ebinnion ebinnion deleted the update/invites-center-button-text branch December 2, 2015 18:29
@scruffian scruffian removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 2, 2015
@lancewillett lancewillett removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Oct 19, 2016
@anarh anarh mentioned this pull request Nov 28, 2023
Open
@mdno mdno mentioned this pull request Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ebinnion ebinnion

Labels
People Management
Projects
None yet
Milestone
People Management: m6
Development

Successfully merging this pull request may close these issues.
5 participants
@ebinnion @roccotripaldi @rickybanister @lancewillett @scruffian