Purchases: Use /sites/:site_slug/purchases endpoint in UpgradesActions
#1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewblaisdell
added
[Status] Needs Review
2 tasks
|
LGTM 👍 |
scruffian
added
[Status] Ready to Merge
and removed
[Status] Needs Review
scruffian
force-pushed
the
update/site-purchases-endpoint
branch
from
8f7ab22 to
0951f26
Compare
scruffian
added a commit
that referenced
this pull request
Dec 1, 2015
Purchases: Use `/sites/:site_slug/purchases` endpoint in `UpgradesActions`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disparity between the site upgrades and user purchases endpoints (specifically, the lack of a
renew_dateproperty) is causing issues when a user visits the delete site component before visiting/purchases. This PR/patch will updatefetchSitePurchasesto fetch actual purchase objects through a new endpoint.Requires patch
D-587, which adds the new endpoint.Testing
/settings/general/:sitefor a site with active subscriptions and click 'Delete Site'./settings/general/:sitefor a site with no active subscriptions and click 'Delete Site'.Props to @scruffian for noticing this.