Domains: add missing name attribute in SRV form #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klimeryk
added
[Type] Bug
|
I verified the bug in production. It looks like there's an extra js error being thrown here when toggling the protocol dropdown which is preventing me from saving an SRV record on your branch. |
The name attribute for the field was missing as well as a default value.
klimeryk
force-pushed
the
fix/missing-protocol-field-in-srv
branch
from
7b6acc2 to
bad86e2
Compare
|
|
gwwar
added
[Status] Ready to Merge
and removed
[Status] Needs Review
klimeryk
pushed a commit
that referenced
this pull request
Dec 2, 2015
…n-srv Domains: add missing name attribute in SRV form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
protocolfield was missing anameattribute. And since it's a mandatory field, the backend did not allow saving a SRV record at all.Interesting that no one reported this - but then again,
SRVrecords are not that often used.