Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Fix subscriptions import button styles #100655

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

artemiomorales
Copy link
Contributor

Related to #100654

Proposed Changes

  • Fixes styles for import button

Why are these changes being made?

  • Users with unverified emails would see the import button misaligned
  • This is due to the HTML structure of the button being slightly different (just a label) when your email is not verified

Before

Screenshot 2025-02-28 at 20 22 36

After

Screenshot 2025-02-28 at 20 37 04

Testing Instructions

  • Create an unverified account
  • Go to Manage Subscriptions > More
  • See that the import button renders as expected

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@artemiomorales artemiomorales self-assigned this Feb 28, 2025
@artemiomorales artemiomorales added the [Feature] Reader The reader site on Calypso. label Feb 28, 2025
@artemiomorales artemiomorales marked this pull request as ready for review February 28, 2025 19:42
@artemiomorales artemiomorales requested a review from a team as a code owner February 28, 2025 19:42
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 28, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/opml-import-button-styles on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Reader The reader site on Calypso. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants