Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper: Migrate hosted site flow to use built in auth #100651

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

alshakero
Copy link
Member

@alshakero alshakero commented Feb 28, 2025

Proposed Changes

This migrates the new-hosted-site flow to use built-in Stepper auth. This is much faster to load and makes all the navigations SPA-style. It also enables preloading of the following steps in the flow.

Why are these changes being made?

Mostly performance.

Testing Instructions

  1. Please test the flow thoroughly around auth.
  2. Try to use it while logged in.
  3. Try to use it while logged out by signing up.
  4. Try to use it while logged out by signing in.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug upgradte/new-hosted-flow-user on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Feb 28, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~8 bytes removed 📉 [gzipped])

name                  parsed_size           gzip_size
new-hosted-site-flow        -51 B  (-0.0%)       -8 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@escapemanuele escapemanuele self-requested a review February 28, 2025 17:53
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 28, 2025
@alshakero alshakero requested a review from zaguiini February 28, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants