-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: Add post in API response to feed #100572
Conversation
f803f48
to
bab04f3
Compare
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~220 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~36 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
isSynthetic: true, | ||
}; | ||
return [ newPost, ...state ]; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than use this isSynthetic
flag, what I want to do is introduce a new object called temporaryItems
or similar in the posts
store, which we would populate with the API response, and use that in conjunction with the regular items
property from the posts
store when rendering the Stream component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
Related to https://github.com/Automattic/loop/issues/519
Proposed Changes
reader/quick-post-v2
config flagstream
store when behind the config flagisSynthetic
property to the post so we can determine whether to render it in thesteam
componentreader-quick-post.mp4
Why are these changes being made?
Testing Instructions
/reader?flags=reader/quick-post,reader/quick-post-v2
Pre-merge Checklist