Framework: Change SVG attributes to camelCase #5950
Labels
Comments
obenland
added a commit
that referenced
this issue
Oct 7, 2016
Avoids two “Unknown DOM property” warnings when displaying sharing options in `my-sites/sharing`. See https://facebook.github.io/react/docs/tags-and-attributes.html#svg-attri butes See #5950.
obenland
added a commit
that referenced
this issue
Oct 7, 2016
Avoids two “Unknown DOM property” warnings when displaying sharing options in `my-sites/sharing`. See https://facebook.github.io/react/docs/tags-and-attributes.html#svg-attri butes See #5950.
|
This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week. If you would like it to remain open, can you please comment below and see what you can do to get things moving with this issue? Thanks! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
React 15 enables all SVG attributes -- but as with all things React, they're
camelCased. We do have some inline<svg>s, but some of them have been using attributes likefill-rulethat have been ignored. We should change those to camelCase. This will be more complicated with generated code (Gridicons,SocialLogos). Fortunately, AFAICS this doesn't seem to break any existing functionality, so we can tackle this after the React 15 upgrade (#5116).This will also allow us to stop relying on SVGs defined in string
consts and then rendered usingdangerouslySetInnerHTML. I've started a PR for this, #5164.The text was updated successfully, but these errors were encountered: