Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes: Related themes #3164

Closed
3 tasks
ehg opened this issue Feb 8, 2016 · 5 comments
Closed
3 tasks

Themes: Related themes #3164

ehg opened this issue Feb 8, 2016 · 5 comments
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] Low Address when resources are available. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Milestone
Themes: Showcase ...

Comments

@ehg
Copy link
Member

ehg commented Feb 8, 2016

We want to show related themes on the theme sheet page.

TODO:

  • Get related themes from details endpoint, using ES?
  • Show two related Themes
  • Add footer

UI:
screen shot 2016-01-21 at 19 06 55
@ehg ehg added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature Group] Appearance & Themes Features related to the appearance of sites. labels Feb 8, 2016
@ehg ehg added this to the Themes: Showcase M4-ThemeSheets milestone Feb 8, 2016
@folletto folletto added the [Pri] Low Address when resources are available. label Mar 2, 2016
@folletto
Copy link
Contributor

folletto commented May 17, 2016 •
edited
Loading

We decided to proceed on this incrementally:

  • Step 1 (MVP) — We take always two themes from a subset of hard-coded themes. With this we'll check if the feature is used and how much.
  • Step 2 (Related API) — We create a proper API that returns the related themes based on tags, swapping the subset done in Step 1.

Step 1 is the feature considered part of M4.

@alaczek
Copy link
Contributor

alaczek commented May 17, 2016

Step 1 (MVP) — We take always two themes from a subset of hard-coded themes.

I came up with a list of 10 candidates that present a cross-section of our theme offering:

  • Twenty Sixteen
  • Rowling
  • Hemingway Rewritten
  • Gazette
  • Ecto
  • Isola
  • Edin
  • Sela
  • Pique
  • Harmonic

Hope this helps!

@seear
Copy link
Contributor

seear commented May 26, 2016

@budzanowski: For the theme data, you can do something very similar to how it is done in signup here:
https://github.com/Automattic/wp-calypso/blob/master/client/signup/steps/theme-selection/index.jsx#L29
(and note the screenshot url below).
So no data fetching will be necessary, which will keep it nice and simple :D

@budzanowski
Copy link
Contributor

Nice hint @seear!

budzanowski added a commit that referenced this issue May 27, 2016
@budzanowski
Initial commit for issue #3164 Related Themes feature
0462ca5 
This commit introduces section header that will be used
with this feature.
@budzanowski budzanowski mentioned this issue May 27, 2016
Merged
budzanowski added a commit that referenced this issue Jun 2, 2016
@budzanowski
Footer and styling for footer added for issue #3164.
84d20dc 
Footer is a simple p tag with a link. Link now points
to wp.com and needs updationg to proper location.
budzanowski added a commit that referenced this issue Jun 10, 2016
@budzanowski
Initial commit for issue #3164 Related Themes feature
4b7d8a3 
This commit introduces section header that will be used
with this feature.
budzanowski added a commit that referenced this issue Jun 10, 2016
@budzanowski
Footer and styling for footer added for issue #3164.
c04ac45 
Footer is a simple p tag with a link. Link now points
to wp.com and needs updationg to proper location.
budzanowski added a commit that referenced this issue Jun 12, 2016
@budzanowski
Themes: Show Related Themes feature #3164 (#5629)
a69bd6c 
Related Themes feature(issue #3164)

Theme sheet shows user two suggestions of themes
user may also like. This implementation uses static
list of suggestions. In future selection will be based
on current theme features.
budzanowski added a commit that referenced this issue Jun 12, 2016
@budzanowski
Revert "Themes: Show Related Themes feature #3164"
4cb3cab
budzanowski added a commit that referenced this issue Jun 12, 2016
@budzanowski
Revert "Themes: Show Related Themes feature #3164" (#5982)
95b1eb0
budzanowski added a commit that referenced this issue Jun 13, 2016
@budzanowski
Update/3164 related themes (#5986)
a9b45a9 
Related Themes feature, part one.

This PR implements first part of #3164
Suggested themes are fixed and taken from predefined list.
@folletto
Copy link
Contributor

Closing, this was done in #5629.

@snyk-bot snyk-bot mentioned this issue Jun 13, 2022
Open
@awaisab172 awaisab172 mentioned this issue Apr 30, 2023
Open
@awaisab172 awaisab172 mentioned this issue Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] Low Address when resources are available. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
Themes: Showcase M4-ThemeSheets
Development

No branches or pull requests
5 participants
@folletto @ehg @alaczek @seear @budzanowski