-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purchases: weird button state when cancelling private registration #195
Comments
This seems related to #221. /cc @mikeshelton1503 |
Yes looks like the same thing though the blue border just looks like the browser default blue focus state (I'm not looking at in though, I'm on mobile). In #221 I suggested a fix but that would be for v2. In the meantime we could change the button copy to say something like "Canceling ..." Or "Processing ..." while it is processing the cancelation. |
Do you think we should remove the focus state css as well, or just change the wording on the button while it's processing? |
…Processing..." on click (Fixes #195)
Sorry, yes let's remove it as well. |
I'm OK with removing it, but this might cause some accessibility issues: http://stackoverflow.com/a/25298082/825780 I'm removing it right now, but we might need a better way to highlight the focused buttons at some point. |
Yes this will just be a temporary solution. I'm still on mobile (AFK today) so I can't check but if you just match it to the behavior of our other buttons that will be best (I can't remember if the focus state is disabled or not). |
SiteAdCreditVouchers: first implementation
The Cancel button in the Cancel Private Registration screen becomes white with a blue border when clicked. This is confusing, as it makes it look like something went wrong or broke -- especially since there's no processing indicator and it's unclear wither the cancellation is happening or not.
This is what it looks like in Firefox 40.0.3 for Linux:
As far as I can see, other products have the same issue in the Cancel button, but it seems to be more prominent with Private Registration.
The text was updated successfully, but these errors were encountered: