Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchases: weird button state when cancelling private registration #195

Closed
fabianapsimoes opened this issue Nov 19, 2015 · 6 comments
Closed
Assignees
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@fabianapsimoes
Copy link
Contributor

The Cancel button in the Cancel Private Registration screen becomes white with a blue border when clicked. This is confusing, as it makes it look like something went wrong or broke -- especially since there's no processing indicator and it's unclear wither the cancellation is happening or not.

This is what it looks like in Firefox 40.0.3 for Linux:

screenshot-wpcalypso wordpress com 2015-11-19 16-47-33

As far as I can see, other products have the same issue in the Cancel button, but it seems to be more prominent with Private Registration.

@fabianapsimoes fabianapsimoes added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Upgrades labels Nov 19, 2015
@fabianapsimoes fabianapsimoes modified the milestones: Purchases: Manage, Purchases: v1 Nov 19, 2015
@fabianapsimoes fabianapsimoes added [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. and removed [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. Upgrades labels Nov 20, 2015
@fabianapsimoes
Copy link
Contributor Author

This seems related to #221.

/cc @mikeshelton1503

@mikeshelton1503
Copy link
Contributor

Yes looks like the same thing though the blue border just looks like the browser default blue focus state (I'm not looking at in though, I'm on mobile). In #221 I suggested a fix but that would be for v2.

In the meantime we could change the button copy to say something like "Canceling ..." Or "Processing ..." while it is processing the cancelation.

@umurkontaci
Copy link
Contributor

Do you think we should remove the focus state css as well, or just change the wording on the button while it's processing?

umurkontaci added a commit that referenced this issue Nov 23, 2015
@mikeshelton1503
Copy link
Contributor

Sorry, yes let's remove it as well.

@umurkontaci
Copy link
Contributor

I'm OK with removing it, but this might cause some accessibility issues: http://stackoverflow.com/a/25298082/825780

I'm removing it right now, but we might need a better way to highlight the focused buttons at some point.

@umurkontaci umurkontaci added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Nov 23, 2015
@mikeshelton1503
Copy link
Contributor

Yes this will just be a temporary solution. I'm still on mobile (AFK today) so I can't check but if you just match it to the behavior of our other buttons that will be best (I can't remember if the focus state is disabled or not).

@umurkontaci umurkontaci removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 26, 2015
jsnajdr pushed a commit that referenced this issue Jan 27, 2020
SiteAdCreditVouchers: first implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

3 participants