Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store: No Taxes - Tax Column Should Be Hidden #17911

Closed
timmyc opened this issue Sep 7, 2017 · 3 comments
Closed

Store: No Taxes - Tax Column Should Be Hidden #17911

timmyc opened this issue Sep 7, 2017 · 3 comments
Labels
Design Store [Type] Bug When a feature is broken and / or not performing as intended

Comments

@timmyc
Copy link
Contributor

timmyc commented Sep 7, 2017

Somewhat related to #17910 - On Stores that either have the setting for "Taxes are included in Product Prices" checked "on" or, in my case, you live in a locale where no sales tax is collected and TaxJar says: "Since your store is located in Oregon, USA you're not required to collect sales tax." should we consider hiding all tax-related UI in the store admin?

It appears that in core the tax bits are hidden when no tax is collected:

edit_order_ care_for_animals _wordpress

@ryelle
Copy link
Member

ryelle commented Sep 7, 2017

Can you screenshot an order in Calypso where you see the tax column? We should be hiding it in the totals section already.

@timmyc
Copy link
Contributor Author

timmyc commented Sep 7, 2017

Sure thing:

order_details_ care_for_animals _wordpress_com

@rachelmcr rachelmcr added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Sep 8, 2017
@timmyc timmyc added [Type] Bug When a feature is broken and / or not performing as intended and removed [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Dec 21, 2017
@apeatling apeatling modified the milestone: Product Quality Jan 31, 2018
@ryelle
Copy link
Member

ryelle commented Feb 8, 2018

Fixed in #22019

@ryelle ryelle closed this as completed Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Store [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

4 participants