Skip to content

Commit

Permalink
Make the name of the client property in config files more generic.
Browse files Browse the repository at this point in the history
This lets us reuse the value in places besides its current use in Tracks
without just using the Tracks-specific name, which would ultimately
become confusing and inaccurate.
  • Loading branch information
dllh committed Feb 16, 2016
1 parent b6140c2 commit 86014ff
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion client/analytics/super-props.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ module.exports = {
environment: config( 'env' ),
site_count: sites.data ? sites.data.length : 0,
site_id_label: 'wpcom',
client: config( 'tracks_client_prop' )
client: config( 'client_slug' )
};

if ( selectedSite ) {
Expand Down
2 changes: 1 addition & 1 deletion config/client.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[
"env",
"tracks_client_prop",
"client_slug",
"hostname",
"wpcom_user_bootstrap",
"oauth_response_type",
Expand Down
2 changes: 1 addition & 1 deletion config/desktop-mac-app-store.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"env": "production",
"tracks_client_prop": "mac-app-store",
"client_slug": "mac-app-store",
"hostname": "127.0.0.1",
"i18n_default_locale_slug": "en",
"wpcom_user_bootstrap": false,
Expand Down
2 changes: 1 addition & 1 deletion config/desktop.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"env": "production",
"tracks_client_prop": "desktop",
"client_slug": "desktop",
"hostname": "127.0.0.1",
"i18n_default_locale_slug": "en",
"wpcom_user_bootstrap": false,
Expand Down
2 changes: 1 addition & 1 deletion config/development.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"env": "development",
"tracks_client_prop": "browser",
"client_slug": "browser",
"hostname": "calypso.localhost",
"port": 3000,
"i18n_default_locale_slug": "en",
Expand Down
2 changes: 1 addition & 1 deletion config/horizon.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"env": "production",
"tracks_client_prop": "browser",
"client_slug": "browser",
"hostname": "horizon.wordpress.com",
"i18n_default_locale_slug": "en",
"wpcom_user_bootstrap": true,
Expand Down
2 changes: 1 addition & 1 deletion config/production.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"env": "production",
"tracks_client_prop": "browser",
"client_slug": "browser",
"hostname": "wordpress.com",
"i18n_default_locale_slug": "en",
"wpcom_user_bootstrap": true,
Expand Down
2 changes: 1 addition & 1 deletion config/stage.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"env": "production",
"tracks_client_prop": "browser",
"client_slug": "browser",
"hostname": "wordpress.com",
"i18n_default_locale_slug": "en",
"wpcom_user_bootstrap": true,
Expand Down
2 changes: 1 addition & 1 deletion config/wpcalypso.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"env": "production",
"tracks_client_prop": "browser",
"client_slug": "browser",
"hostname": "wpcalypso.wordpress.com",
"i18n_default_locale_slug": "en",
"wpcom_user_bootstrap": true,
Expand Down

0 comments on commit 86014ff

Please sign in to comment.