Skip to content

Commit

Permalink
Merge pull request #5605 from Automattic/Fix/reader-prev-next-error
Browse files Browse the repository at this point in the history
Reader: Fix uncaught error in prev/nextItem selection handling
  • Loading branch information
nb committed May 30, 2016
2 parents dec96e3 + 056e698 commit 113b13f
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions client/reader/following-stream/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -233,12 +233,16 @@ module.exports = React.createClass( {
return !! window.location.pathname.match( /^\/read\/(blogs|feeds)\/([0-9]+)\/posts\/([0-9]+)$/i );
},

getVisibleItemIndexes: function() {
return this._list && this._list.getVisibleItemIndexes( { offsetTop: HEADER_OFFSET_TOP } );
},

selectNextItem: function() {
var visibleIndexes = this._list.getVisibleItemIndexes( { offsetTop: HEADER_OFFSET_TOP } ),
var visibleIndexes = this.getVisibleItemIndexes(),
visibleIndex,
index,
i;
if ( visibleIndexes.length > 0 ) {
if ( visibleIndexes && visibleIndexes.length > 0 ) {
index = visibleIndexes[ 0 ].index;
for ( i = 0; i < visibleIndexes.length; i++ ) {
visibleIndex = visibleIndexes[ i ];
Expand All @@ -256,11 +260,11 @@ module.exports = React.createClass( {
},

selectPrevItem: function() {
var visibleIndexes = this._list.getVisibleItemIndexes( { offsetTop: HEADER_OFFSET_TOP } ),
var visibleIndexes = this.getVisibleItemIndexes(),
visibleIndex,
index,
i;
if ( visibleIndexes.length > 0 ) {
if ( visibleIndexes && visibleIndexes.length > 0 ) {
index = visibleIndexes[ 0 ].index;
for ( i = 0; i < visibleIndexes.length; i++ ) {
visibleIndex = visibleIndexes[ i ];
Expand Down

0 comments on commit 113b13f

Please sign in to comment.