Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: set_object falsely overwrites the Activity-ID with a default #1318

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Fix: set_object falsely overwrites the Activity-ID with a default #1318

merged 5 commits into from
Feb 13, 2025

Conversation

pfefferle
Copy link
Member

@pfefferle pfefferle commented Feb 13, 2025 •
edited
Loading

The Activity::set_object falsely assumes that a URL as string means that there is no Activity-ID available and sets it to a default.

This PR adds a check, if there is already an ID, to not overwrite an existing one any more.

Fixes #1314

Proposed changes:

  • Only set a default, when the ID is empty

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Bypass Signature verification
  • Send a Follow request
  • Check the Outbox Accept item
  • The old code show the default ID
  • With the PR you will see the ID, you have sent with the Follow request

@pfefferle pfefferle self-assigned this Feb 13, 2025
@pfefferle pfefferle requested a review from a team February 13, 2025 09:14
@pfefferle pfefferle merged commit 63fb115 into trunk Feb 13, 2025
11 checks passed
@pfefferle pfefferle deleted the fix/accept-activity-id branch February 13, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obenland obenland obenland approved these changes

Assignees

@pfefferle pfefferle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid Accept activity
2 participants
@pfefferle @obenland