Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Make Fediverse preview template filterable #1098

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

obenland
Copy link
Member

Fixes #967.

Proposed changes:

  • Adds a filter for the preview template path.
  • Adds unit tests for the filter.

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Go to the Editor to create or edit a post.
  • Click Preview > Fediverse Preview.
  • Make sure the preview still works.

@obenland obenland requested a review from a team December 18, 2024 19:10
@obenland obenland self-assigned this Dec 18, 2024
@pfefferle
Copy link
Member

I think this is a nice first step, but I would keep the ticket open, to discuss a template manager, that allows you to view your post in different templates. Or should we file a different issue for that?

/cc @Menrath

pfefferle
pfefferle previously approved these changes Dec 18, 2024
@obenland obenland merged commit 9d9ec68 into trunk Dec 20, 2024
24 checks passed
@obenland obenland deleted the add/preview-filter branch December 20, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add filter to allow custom fediverse previews
2 participants