Improved comment-type handling #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now uses the comment-type as index and keeps a list of mapped activity-types. Also added a function to get the comment-type by the activity-type. `Comment::get_comment_type_by_activity_type ` props @obenland
obenland
reviewed
Dec 11, 2024
|
With this change, |
Co-authored-by: Konstantin Obenland <obenland@gmx.de>
obenland
reviewed
Dec 12, 2024
Covers new and unused methods, as well as deprecated ones
obenland
approved these changes
Dec 12, 2024
| @@ -111,14 +111,13 @@ public static function add_reaction( $activity ) { | |||
| return false; | |||
| } | |||
|
|
|||
| $type = $activity['type']; | |||
| $comment_type = Comment::get_comment_type_by_activity_type( $activity['type'] ); | |||
There was a problem hiding this comment.
Could there ever be multiple comment types for an activity type? Is that something we have to worry about?
There was a problem hiding this comment.
I don't think so... there is the possibility that we might store items in different places (direct messages for example), but that is a different discussion...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now uses the comment-type as index and keeps a list of mapped activity-types.
Also added a function to get the comment-type by the activity-type.
Comment::get_comment_type_by_activity_typeprops @obenland