Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to use plugin folder structure #1049

Merged
merged 6 commits into from
Dec 9, 2024
Merged

Conversation

obenland
Copy link
Member

@obenland obenland commented Dec 6, 2024

Makes it easier to identify file relationships between test and production files and makes filenames easier to read.
It does add a bit of overhead with the namespace being applied to all test files now.

Proposed changes:

  • Mimics folder structure in tests as they are in the plugin.
  • Adds missing namespace declarations to test files that don't have them yet.
  • Updates filenames to be in line with their production counterparts.
  • Fixed a test that failed after the load order changed.

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

Unit tests should suffice.

Before After
Screenshot 2024-12-06 at 1 39 33 PM Screenshot 2024-12-06 at 1 39 18 PM

@obenland obenland added the Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary. label Dec 6, 2024
@obenland obenland requested a review from a team December 6, 2024 19:38
@obenland obenland self-assigned this Dec 6, 2024
@@ -5,12 +5,16 @@
* @package Activitypub
*/

namespace Activitypub\Tests\Activity;
Copy link
Member

@pfefferle pfefferle Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is (despite of the name) in the root includes folder. Just to keep it consistent, until it will be deleted by the inbox PR ;)

@obenland obenland merged commit f07cb12 into trunk Dec 9, 2024
24 checks passed
@obenland obenland deleted the update/test-structure branch December 9, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants