Skip to content
This repository has been archived by the owner on Feb 17, 2025. It is now read-only.

Adds style linting like we do it in Gutenberg #3611

Merged
merged 5 commits into from
Apr 26, 2021
Merged

Conversation

scruffian
Copy link
Member

@scruffian scruffian commented Apr 2, 2021

Changes proposed in this Pull Request:

This adds a stylelint config and also adds stylelint to the pre commit hook so we catch and fix issues in our Sass files.

To test, try committing a change to sass file. You should see warnings about issues in only that file.

@scruffian scruffian requested a review from a team April 23, 2021 17:02
@pbking
Copy link
Contributor

pbking commented Apr 26, 2021

This worked for me and I recommend going forward with bringing it in.

My only suggestion is to remove the lint-css and (especially) the lint-css:fix scripts. The fix in-particular, in my opinion, should never ever be ran. Ensuring everything henceforth is quality sounds great. Fixing everything in the past means one very large commit of questionable value.

@scruffian
Copy link
Member Author

Good call. They were there for testing :)

@scruffian scruffian merged commit 8dd4927 into trunk Apr 26, 2021
@pbking pbking deleted the add/stylelint branch September 13, 2021 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants