Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix svg mock in JS tests #5265

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Jun 13, 2022

Based on #5264

Changes proposed in this Pull Request

Testing instructions

  • Run npm run test-js -- course-upgrade-step
  • Make sure you don't see the warnings: Warning: <SvgrURL /> is using incorrect casing. Use PascalCase for React components, or lowercase for HTML elements.

@renatho renatho requested a review from a team June 13, 2022 14:48
@renatho renatho self-assigned this Jun 13, 2022
@renatho renatho changed the base branch from trunk to feature/course-lesson-wizard June 13, 2022 14:48
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #5265 (375776a) into change/update-course-lesson-wizard (e8de4ec) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 375776a differs from pull request most recent head 0bd46ca. Consider uploading reports for the commit 0bd46ca to get more accurate results

Impacted file tree graph

@@                           Coverage Diff                            @@
##             change/update-course-lesson-wizard    #5265      +/-   ##
========================================================================
- Coverage                                 40.72%   40.70%   -0.02%     
+ Complexity                                 8607     8604       -3     
========================================================================
  Files                                       278      284       +6     
  Lines                                     28998    29012      +14     
========================================================================
+ Hits                                      11808    11809       +1     
- Misses                                    17190    17203      +13     
Impacted Files Coverage Δ
...des/block-patterns/class-sensei-block-patterns.php 11.66% <0.00%> (ø)
...cludes/block-patterns/lesson/default-with-quiz.php 0.00% <0.00%> (ø)
includes/block-patterns/lesson/default.php 0.00% <0.00%> (ø)
...ck-patterns/lesson/templates/default-with-quiz.php 0.00% <0.00%> (ø)
...cludes/block-patterns/lesson/templates/default.php 0.00% <0.00%> (ø)
...ck-patterns/lesson/templates/files-to-download.php 0.00% <0.00%> (ø)
...s/block-patterns/lesson/templates/video-lesson.php 0.00% <ø> (ø)
...s/block-patterns/lesson/templates/zoom-meeting.php 0.00% <0.00%> (ø)
includes/block-patterns/lesson/zoom-meeting.php 0.00% <0.00%> (ø)
includes/blocks/class-sensei-lesson-blocks.php 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8de4ec...0bd46ca. Read the comment docs.

@renatho renatho changed the base branch from feature/course-lesson-wizard to change/update-course-lesson-wizard June 13, 2022 16:20
Copy link
Contributor

@alexsanford alexsanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised!

@alexsanford alexsanford merged commit 922a278 into change/update-course-lesson-wizard Jun 13, 2022
@alexsanford alexsanford deleted the fix/svg-mock branch June 13, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants