[Tooling] Fix update_rollouts
failing on initial submission (draft -> inProgress)
#3341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
During the call to
bundle exec fastlane update_rollouts percent:0.2
, the lane failed to find the release to update the rollout for in Google Play (See internal discussion in p1733749465871129/1733504114.702699-slack-C028JAG44VD):This was because of the way the
upload_to_play_store
action is implemented in fastlane, which only searches for existing releases that are already ininProgress
status when it runs the code to update a rollout.This means that the current fastlane implementation didn't support the possibility to submit an already-existing draft release with an initial rollout. Instead, it was only able to do an initial submission if it was done as part of the initial
upload_to_play_store
that also uploads the.aab
/.apk
, and was only able to update the rollout of a release if that release was alreadyinProgress
and submitted with a lower rollout—but it was not able to promote an existing draft toinProgress
(without doing a new.aab
upload and creating a new release).How?
This PR temporarily points to my fix in the fastlane repo to allow us to call
update_rollouts percent:0.2
for a release that already exists in Play Store Console but in draft state.Once the fix is merged and fastlane ships a new version including it, we shall revert the
Gemfile
to point back to a~> x.y
version constraint.Note
I'm targeting the
release/7.79
branch so that we can benefit from and validate the fix during this sprint and the7.79
release process this week.Testing Instructions
I already tested this by running
bundle exec fastlane update_rollouts percent:0.2
from this branch while the 3 Releases (phone, automotive, wear) for the7.79-rc-1
beta were still in "Draft" status, and confirmed that the fix workedChecklist
If this is a user-facing change, I have added an entry in CHANGELOG.mdN/A./gradlew spotlessApply
to automatically apply formatting/linting)I have considered whether it makes sense to add tests for my changesN/AAll strings that need to be localized are inN/Amodules/services/localization/src/main/res/values/strings.xml
Any jetpack compose components I added or changed are covered by compose previewsN/AI have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.N/A