Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Fix update_rollouts failing on initial submission (draft -> inProgress) #3341

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Dec 9, 2024

Why?

During the call to bundle exec fastlane update_rollouts percent:0.2, the lane failed to find the release to update the rollout for in Google Play (See internal discussion in p1733749465871129/1733504114.702699-slack-C028JAG44VD):

image

This was because of the way the upload_to_play_store action is implemented in fastlane, which only searches for existing releases that are already in inProgress status when it runs the code to update a rollout.

This means that the current fastlane implementation didn't support the possibility to submit an already-existing draft release with an initial rollout. Instead, it was only able to do an initial submission if it was done as part of the initial upload_to_play_store that also uploads the .aab/.apk, and was only able to update the rollout of a release if that release was already inProgress and submitted with a lower rollout—but it was not able to promote an existing draft to inProgress (without doing a new .aab upload and creating a new release).

How?

This PR temporarily points to my fix in the fastlane repo to allow us to call update_rollouts percent:0.2 for a release that already exists in Play Store Console but in draft state.

Once the fix is merged and fastlane ships a new version including it, we shall revert the Gemfile to point back to a ~> x.y version constraint.

Note

I'm targeting the release/7.79 branch so that we can benefit from and validate the fix during this sprint and the 7.79 release process this week.

Testing Instructions

I already tested this by running bundle exec fastlane update_rollouts percent:0.2 from this branch while the 3 Releases (phone, automotive, wear) for the 7.79-rc-1 beta were still in "Draft" status, and confirmed that the fix worked

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md N/A
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes N/A
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml N/A
  • Any jetpack compose components I added or changed are covered by compose previews N/A
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics. N/A

Once a new version of fastlane with the fix ships, we should revert back to point to a version instead of a branch
@AliSoftware AliSoftware changed the base branch from main to release/7.79 December 9, 2024 15:31
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 9, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit6ca16c9
Direct Downloadpocketcasts-app-prototype-build-pr3341-6ca16c9.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit6ca16c9
Direct Downloadpocketcasts-automotive-prototype-build-pr3341-6ca16c9.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit6ca16c9
Direct Downloadpocketcasts-wear-prototype-build-pr3341-6ca16c9.apk

@AliSoftware AliSoftware self-assigned this Dec 9, 2024
@AliSoftware AliSoftware added [Type] Tooling Related to the Gradle build scripts and the setup or maintenance of the project build process. [Area] Tooling labels Dec 9, 2024
@AliSoftware AliSoftware added this to the 7.79 ❄️ milestone Dec 9, 2024
@AliSoftware AliSoftware marked this pull request as ready for review December 9, 2024 15:42
@AliSoftware AliSoftware requested a review from a team as a code owner December 9, 2024 15:42
Copy link
Contributor

@mebarbosa mebarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this PR! The drafted was published in beta now like you said

image

@AliSoftware AliSoftware merged commit be3fe53 into release/7.79 Dec 9, 2024
19 checks passed
@AliSoftware AliSoftware deleted the tooling/fix-update-rollouts branch December 9, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Area] Tooling [Type] Tooling Related to the Gradle build scripts and the setup or maintenance of the project build process.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants