Gridicon: updates the reply icon

[rodrigoi]

Fixes #186

Updates the reply icon for consistency with the latest release of gridicons, since we are not using the npm package, but a subset of icons on src/templates/gridicons.jsx

notifications-panel/src/templates/gridicons.jsx

Line 192 in 5ef6610

case 'gridicons-reply':

Maybe we should consider using the npm package instead...

To test:

• run the local environment
• find a notification of a comment with a reply
• both the list view and the detail view should show the reply icon pointing to the right.

Before	After

References:
Automattic/gridicons#255
Automattic/wp-calypso#18891

[gwwar]

Tests well for me, thanks @rodrigoi!

[kwight]

Sweet, works great for me too 👍

[kwight]

Maybe we should consider using the npm package instead...

If we're only using a handful (looks like roughly 1/8 of them), and they change fairly rarely, I'd vote for us continuing to save the bits transferred and keep manually patching until it becomes more of an issue.

[dmsnell]

Last time I checked, the gridicons were written in such a way that they were all bundled up together and the npm import was disproportionately huge compared to our needs.

On the other hand, if it's updated, or if we update it, so that it can also create ES modules and we can import only the ones we want and let webpack trim down the bundle then that's a more stable long-term solution

[jancavan]

I'm still seeing the old icon?

[rodrigoi]

I'm still seeing the old icon?

this hasn't been deployed yet. Will let you know when it is 😉

[kwight]

@jancavan This is in production now 👍

[jancavan]

@kwight @rodrigoi Looks good, thanks!