WPCOM merge: list post type taxonomies endpoint #9428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This revision seeks to resolve an issue where localized requests for taxonomies for themes where custom taxonomy associations exist will not preserve those associations. For example, themes where "featured-content" is supported (e.g. Sketch) register the "post_tag" taxonomy for "page" types. If a request is issued with locale specified for this site to retrieve page taxonomies, previously the "post_tag" taxonomy was not returned. The fix here is to track taxonomies for the requested post type before calling this method, then reapplying them after create_initial_taxonomies is called. We need to call create_initial_taxonomies because it runs very early in the page lifecycle, before localization has had a chance to take effect. See: Automattic/wp-calypso#6934 (comment) Differential Revision: D3465 Merges r146417-wpcom.
…that defines it. Details: https://[private link] Merges r161691-wpcom.
nylen
requested review from
jonathansadowski,
zinigor,
oskosk,
michaeldcain,
aduth,
mattsherman and
dereksmart
dereksmart
added
[Feature] WPCOM API
[Status] Ready to Merge
ghost
removed
the
[Status] Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r146417-wpcom - has tests on .com side.