Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load active modules when onboarding #8659

Merged
merged 1 commit into from
Jan 30, 2018
Merged

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Jan 30, 2018

This PR allows active modules to be loaded while onboarding. We need to handle this special case because we might be in a state where we're not connected and not in development mode in the same time, but we still need to load the active modules.

Fixes Automattic/wp-calypso#21930

To test:

  1. Create a fresh Jurassic Ninja site.
  2. Install JP beta, switch on bleeding edge.
  3. SSH into the JN site and apply this branch manually.
  4. Go to https://JNsite.com/wp-admin/admin.php?page=jetpack&action=onboard where JNsite.com is a fresh Jurassic Ninja site.
  5. On the site type step, select Business.
  6. On the Business address step, input your business address and submit the step.
  7. Go to wp-admin and verify that the contact info widget is active and is properly inserted in your sidebar with all the business address inside.

@tyxla tyxla added General [Status] Needs Review This PR is ready for review. labels Jan 30, 2018
@tyxla tyxla added this to the 5.8 milestone Jan 30, 2018
@tyxla tyxla self-assigned this Jan 30, 2018
@tyxla tyxla requested a review from a team as a code owner January 30, 2018 11:08
Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly 👍

@ockham
Copy link
Contributor

ockham commented Jan 30, 2018

Also tested on my JP sandbox. Works great there, too!

@dereksmart
Copy link
Member

Tests well!

@dereksmart dereksmart merged commit 3e05477 into master Jan 30, 2018
@dereksmart dereksmart deleted the fix/jpo-load-modules-properly branch January 30, 2018 15:04
jeherve added a commit that referenced this pull request Jan 30, 2018
zinigor pushed a commit that referenced this pull request Jan 30, 2018
* Changelog 5.8: create base for changelog.

* Update 5.8 release post link

* fix 5.8 release date

* Updates to plugin description

* Changelog: add #8499

* Changelog: add #8506

* Changelog: add #8509

* Changelog: add #8516

* Changelog: add #8517

* Changelog: add #8523

* Changelog: add #8547

* Changelog: add #8496

* Changelog: add #8584

* Changelog: add #8595

* Changelog: add #8445

* Changelog: add #8431

* Changelog: add #8284

* Changelog: add #8270

* Changelog: add #8124

* Changelog: add #8581

* Changelog: add #8463

* Changelog: add #8568 (#8646)

* Updates to testing list and changelog

* Changelog: add #8443

* Changelog: add #8459

* Changelog: add #8469

* Changelog: add #8464

* Changelog: add #8478 and #8479

* Changelog: add #8483

* Changelog: add #8488

* Changelog: add #8513

* Changelog: add #8555

* Changelog: add #8565

* Changelog: add #8601

* Changelog: add #8612

* Changelog: add first pass at Search items.

* Changelog: add more info to help test Search.

* Changelog: add #8144

* Changelog: add #8313

* Changelog: add #8419

* Changelog: add #8465

* Changelog: add #8515

* Changelog: add #8587

* Changelog: add #8591

* Changelog: add #8659

* Changelog: add #8661

* Changelog: add #8671

* Changelog: add 5.7.1 to archived changelog too.

* Reverted changes to readme, removed entry about backups.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants