Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcodes: Check if Brightcove shortcode attributes are an array before assuming they can be counted #8479

Merged
merged 1 commit into from
Jan 10, 2018
Merged

Shortcodes: Check if Brightcove shortcode attributes are an array before assuming they can be counted #8479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/shortcodes/brightcove.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ static public function convert( $atts ) {
* @return array
*/
static public function normalize_attributes( $atts ) {
if ( 1 == count( $atts ) ) { // this is the case we need to take care of.
if ( is_array( $atts ) && 1 == count( $atts ) ) { // this is the case we need to take care of.
$parsed_atts = array();
$params = shortcode_new_to_old_params( $atts );
$params = apply_filters( 'brightcove_dimensions', $params );
Expand Down