Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding PHP 7.2 testing with Travis. #8212

Merged
merged 5 commits into from
Feb 6, 2018
Merged

Adding PHP 7.2 testing with Travis. #8212

merged 5 commits into from
Feb 6, 2018

Conversation

zinigor
Copy link
Member

@zinigor zinigor commented Nov 20, 2017

With more and more people moving to 7.2 we need to introduce automated testing.

@zinigor zinigor requested a review from a team as a code owner November 20, 2017 14:42
@jeherve jeherve mentioned this pull request Nov 20, 2017
Closed
13 tasks
@oskosk oskosk force-pushed the try/travis-php-72 branch 2 times, most recently from eea4450 to e569575 Compare November 22, 2017 19:09
@oskosk
Copy link
Contributor

oskosk commented Nov 22, 2017 •
edited
Loading

  • Usage of count() on a string when it should be only used on arrays was fixed.
  • Tests using create_function were refactored to not fail in PHP 7.2 (create_function is deperecated).

@oskosk oskosk mentioned this pull request Dec 26, 2017
Closed
@oskosk oskosk force-pushed the try/travis-php-72 branch 2 times, most recently from 3877589 to 8012c01 Compare January 6, 2018 21:04
@oskosk
Copy link
Contributor

oskosk commented Jan 6, 2018

I removed the commits I initally added to this PR and cherrypicked them into individual PRs (#8478 and #8479) to address the issues there. This PHP 7.2 run won't pass until core updates some code.

@zinigor zinigor added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Feb 5, 2018
oskosk
oskosk approved these changes Feb 5, 2018
View reviewed changes
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 !

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 5, 2018
jeherve
jeherve reviewed Feb 6, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick nitpick, but it should be good to merge.

tests/php/sync/test_class.jetpack-sync-plugins-updates.php Outdated
if ( defined( 'PHP_VERSION_ID' ) && PHP_VERSION_ID < 50300 ) {
$this->markTestIncomplete("Right now this doesn't work on PHP 5.2");
$this->markTestIncomplete( "Right now this doesn't work on PHP 5.2");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you added a space before the first ", maybe you want to add one at the end as well?

@zinigor
Copy link
Member Author

zinigor commented Feb 6, 2018

Thanks for taking a look, Jeremy! Fixed it, let's see if Travis passes this time :trollface:

jeherve
jeherve approved these changes Feb 6, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay. Merging!

@jeherve jeherve merged commit 4411b29 into master Feb 6, 2018
@jeherve jeherve deleted the try/travis-php-72 branch February 6, 2018 16:44
@jeherve jeherve removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@oskosk oskosk oskosk approved these changes

Assignees
No one assigned
Labels
General Unit Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zinigor @oskosk @jeherve @matticbot