Added a WP CLI command to rebuild the sitemap. #7930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help in testing and will allow users at least a low level way to rebuild the sitemap.
zinigor
added
[Feature] Sitemaps
[Status] Needs Review
oskosk
reviewed
Oct 23, 2017
jeherve
added
[Status] Needs Author Reply
oskosk
reviewed
Nov 10, 2017
| * @synopsis <rebuild> | ||
| */ | ||
| public function sitemap( $args, $assoc_args ) { | ||
| if ( ! Jetpack::is_active() ) { |
There was a problem hiding this comment.
Can we check if sitemaps is active too?
oskosk
reviewed
Nov 10, 2017
class.jetpack-cli.php
Outdated
| WP_CLI::error( __( 'Jetpack is not currently connected to WordPress.com', 'jetpack' ) ); | ||
| } | ||
| if ( ! Jetpack::is_module_active( 'sitemaps' ) ) { | ||
| WP_CLI::error( __( 'Jetpack Sitemaps module is not currently active. Activate it if first if you want to work with sitemaps.', 'jetpack' ) ); |
There was a problem hiding this comment.
There's a typo here: Activate it if first if. Two ifs.
|
I'm still getting the error when By |
oskosk
approved these changes
Nov 10, 2017
oskosk
added
[Status] Ready to Merge
jeherve
added a commit
that referenced
this pull request
Nov 24, 2017
oskosk
pushed a commit
that referenced
this pull request
Nov 28, 2017
* Changelog 5.6: create base for changelog. * Update changelog with 5.5.1 info. * Changelog: add #7930 and #8238 * Changelog: add #8076 * Changelog: add #8100 * Changelog: add #8117 * Changelog: add #8141 * Changelog: add #8143 * Changelog: add #8147 * Changelog: add #8149 * Changelog: add #8153 * Changelog: add #8173 * Changelog: add #8184 * Changelog: add #8196 * Changelog: add #8199 * Changelog: add #8093 * Changelog: add #8171 * Changelog: add #8182 * Changelog: add #8202, #8222 * Changelog: add #8228 * Changelog: add #8240 * Changelog: add #8251 * remove AL card change
kraftbj
removed
the
[Status] Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help in testing and will allow users at least a low level way to rebuild the sitemap.
Changes proposed in this Pull Request:
Proposed changelog entry for your changes: